Conversation
Test dsl improvements Adjust to latest golem-wit changes (host side) Adjust to latest golem-wit changes Changed how wit dependencies are fetched
| dependencies = ["wit-host"] | ||
| script_runner = "@duckscript" | ||
| script = """ | ||
| rm -r wasm-rpc/wit/deps |
There was a problem hiding this comment.
do we really want to delete and re-get the deps on basically every command? (i know that wit-deps uses a cache, and probably not a huge performance problem, still feels wasteful)
There was a problem hiding this comment.
This is not "regetting" them just copying them from the project root's wit/deps. We can try to make a better script for it but
- it needs to be working on all platforms - that's why i used this 🦆 thing
- it needs to remove things that are no longer there - i already ran into that multiple times as i was trying to figure out the proper name for the new wit package
There was a problem hiding this comment.
by "regetting" i meant wit-host also runs on everything now, and yes, i understand that it would need a "task checker", will think about it (ironically golem-cli app could do it :D)
There was a problem hiding this comment.
The wit-dep update is designed to be runnable every time. That's why it keeps a lock file.
There was a problem hiding this comment.
(Based on bytecodealliance/wit-deps#202 being closed)
* Final durability related refactorings Test dsl improvements Adjust to latest golem-wit changes (host side) Adjust to latest golem-wit changes Changed how wit dependencies are fetched * Undo some more * Fix * Revert test change * Fix metadata check * Fix
2 participants
The useful parts of #1240 that we decided to not finish:
wit-depsbased fetch and then creating separate subsets for various purposes. In the original PR this was required to create thewit/depsdirectory ofdurable-wasi, but even without that I think it is better than the previous, custombuild.rsbased solution.golem-commonthat were used to minimize the dependencies used bydurable-wasi, but it makes sense to have them anywayResolves #1225